On search results, highlight searched word in item title - issue #11996 #16484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 35752ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16484. |
|
I have tested this item ✅ successfully on 35752ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16484. |
|
RTC after two successful tests. |
joomla-cms-bot
added
PR-staging
and removed
RTC
ghost
mentioned this pull request
|
We found the following behaviour: When your search string was "joomla", and the original string in the title line was "JOOMLA", you get "joomla" as highlighted keyword in the title line of the search result. (Whereas, in the snippet from the article´s content below the title line in the search result, capitalization from the original content is maintained.) Hence, you do not get the original writing of the keyword in the title, but a modified writing using the search string which was entered. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16484. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #11996 .
Summary of Changes
Highlight a search result title, instead of only highlighting them in an article snippet.
Testing Instructions
See Issue #11996.
On stock Joomla, with sample data, search for the word "Joomla".
Expected result
At least one article has the word "Joomla" only in its title. This instance of "joomla" should be highlighted. Other instances in article snippets should still be highlighed.
Documentation Changes Required
#jab17